Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements lint rule per message/ per variant configuration #5

Open
Tracked by #10
LorisSigrist opened this issue Mar 20, 2024 — with Linear · 3 comments
Open
Tracked by #10

requirements lint rule per message/ per variant configuration #5

LorisSigrist opened this issue Mar 20, 2024 — with Linear · 3 comments

Comments

Copy link
Member

Problem

Lint rules are all or nothing. There is no way to ignore a warning coming from a lint rule just for a specific message.

This is especially annoying with the "duplicate pattern" lint rule which has a lot of false positives.

This has been a common complaint

Proposal

Some way to ignore lint warnings for specific messages.

This would likely require annotating messages with metadata.

cc @felix.haeberle

Copy link

linear bot commented Mar 20, 2024

@samuelstroschein samuelstroschein changed the title More Fine-Grained Lint Rule Lint rule per message/ per variant configuration Mar 20, 2024
Copy link
Member

@loris.sigrist nice feature. came up several times. I propose to create a project out of this because it requires multiple teams to collaborate/is not a one off issue.

  • storing per message configuration
  • storing per variant configuration
  • updating the upcoming <inlang-settings> component to make this configurable
  • updating the upcoming <inlang-message-editor> component to "one click" ignore lints for a message/variant
  • show in <inlang-message-editor> component that a lint rule is ignored for a message/variant

Copy link
Member

@loris.sigrist agree to turn this into a project?

Maybe leave this issue open for external collaborators to upvote this issue & discuss.

@jldec jldec mentioned this issue Mar 27, 2024
5 tasks
@samuelstroschein samuelstroschein changed the title Lint rule per message/ per variant configuration requirements lint rule per message/ per variant configuration Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants