Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings component should have ability to rename the project #76

Open
samuelstroschein opened this issue Jun 13, 2024 — with Linear · 1 comment
Open

settings component should have ability to rename the project #76

samuelstroschein opened this issue Jun 13, 2024 — with Linear · 1 comment
Assignees

Comments

Copy link
Member

samuelstroschein commented Jun 13, 2024

Context

FINK-55 requires the user the ability to rename a project [without opening the filesystem, manually rename the file, etc.]

Proposal

Add the possibility to rename a project.

Flow

  1. User sees field to rename a project

CleanShot 2024-06-13 at 07.02.36@2x.png

  1. Upon clicking on "rename", a dialog pops up that warns about unintended side effects.

CleanShot 2024-06-13 at 07.07.05@2x.png

Additional information

How to do this without having access to the project API in the component?

  onProjectNameChange={(name) => project.rename(name)}
>
@NilsJacobsen NilsJacobsen self-assigned this Jun 17, 2024
Copy link
Member

Good point, I also talked to Niklas about that.

Challenges:

  • Renaming the project would probably reload the project -> you lose the other save states
  • Other app's settings handle stuff like that on other settings pages to have scoped save states -> but I don't wanna make it too big.

Gonna see what we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants