-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Vscode extension v1.29.4
failing to load project
#2162
Comments
v1.29.4
failing to load project
@iolyd Can you probably share a minimal reproduction? I can't reproduce it with my setup. cc @janfjohannes Probably related: https://discord.com/channels/897438559458430986/1085193211577897070/1200807711412068453 This is the only change which has been done in this file regarding the loading logic since the 1.29.0 release: 990803e see project.ts file / the fs fix you did? @janfjohannes Can you investigate if |
@opral/team does any of you have problems with the latest vs code extension? I can't reproduce this on my side. edit: 3 additional team member can't reproduce this with |
@iolyd can you possibly share your |
Same problem here: {
"$schema": "https://inlang.com/schema/project-settings",
"sourceLanguageTag": "en",
"languageTags": [
"en", "de"
],
"modules": [
"https://cdn.jsdelivr.net/npm/@inlang/plugin-next-intl@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-empty-pattern@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-identical-pattern@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-missing-translation@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-without-source@latest/dist/index.js"
],
"plugin.inlang.nextIntl": {
"pathPattern": "./examples/example-app-router/messages/{languageTag}.json"
}
}
Error: |
I updated my vscode from 1.85 to 1.86 that solved it for me @iolyd |
@felixhaeberle i dont see any openRepo or loadProject in the linked commit. but i assume this is closed and solved anyways... |
Ony my side, the problem persists after updating code to Here's my project config: {
"$schema": "https://inlang.com/schema/project-settings",
"sourceLanguageTag": "fr",
"languageTags": ["fr", "en"],
"modules": [
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-empty-pattern@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-identical-pattern@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-missing-translation@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-without-source@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/plugin-message-format@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/plugin-m-function-matcher@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-snake-case-id@latest/dist/index.js"
],
"plugin.inlang.messageFormat": {
"pathPattern": "./project.inlang/{languageTag}.json"
}
} (I know putting the message files alongside the settings file is probably not clean, but it hasn't caused any problem with paraglide.) I also tested with another smaller project scaffolded more recently using {
"$schema": "https://inlang.com/schema/project-settings",
"sourceLanguageTag": "fr",
"languageTags": ["fr", "en"],
"modules": [
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-empty-pattern@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-identical-pattern@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-missing-translation@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-without-source@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/message-lint-rule-valid-js-identifier@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/plugin-message-format@latest/dist/index.js",
"https://cdn.jsdelivr.net/npm/@inlang/plugin-m-function-matcher@latest/dist/index.js"
],
"plugin.inlang.messageFormat": {
"pathPattern": "./messages/{languageTag}.json"
}
} Both are SvelteKit projects. If just scaffolding a new SvelteKit project and then going through the paraglide setup doesn't give you the error, I don't really see how I could share a repro with anything more relevant. |
@iolyd Is it possible that you can post a stack trace for this error?
What did you change to trigger the error? |
Sure thing!
|
We are experiencing the same problem, config is here. Downgrading to |
@utkubakir & @iolyd Can you verify that the issue first happened on v1.29.1 ? @janfjohannes @jldec The IDE extension got a version bump from both I can only see the issue in the SDK, because nothing has changed from the IDE extension in regards to See monorepo/inlang/source-code/sdk/src/loadProject.ts Lines 104 to 105 in e765a65
@jldec Can you take over? |
@felixhaeberle Yes I can confirm the error first happens on |
@felixhaeberle or @LorisSigrist are you able to repro this based on the information provided? |
@iolyd & @utkubakir – we can't reproduce it on our side but push a fix regardless based on the error shown above. can you test with the latest version thank you for your patience! 🙏 |
@felixhaeberle, yeah I saw the update roll out not long ago and tried it. The error persists, but the logs are a bit different now:
I tried making a completely new SvelteKit project from scratch with Paraglide and it appears to work in that repo, so there's definitely something related to how previous projects were setup. The thing is... one of my projects where the extension is throwing the error was scaffolded barely 3 weeks ago and didn't really have much work done in it, even less so when it comes to configs. I'll try and go my way back from where it is and see if I can pinpoint at which point the extension breaks. Also, seeing as I'm not alone with this problem, I suggest keeping the issue open in the meantime. |
@LorisSigrist @janfjohannes @jldec Can you think of any change happening here?
@iolyd Sure, sorry for closing too early. 🙏 We will fix this. |
@felixhaeberle Got it figured out! Or somewhat figured out. For some reason, my older projects would not generate the |
cc @janfjohannes did you implement the |
see #2070 |
@samuelstroschein here is my understanding on this issue We do not have a proper repro for this, but we have a theory that project.settings are undefined during some part of the initialization. and @LorisSigrist pushed #2166 as a workaround/fix. I have added this issue to the list in #1772 This issue is unrelated to #2070. |
adding additional comment here because there was confusion about project id generation see #2101 (comment) |
@felixhaeberle yes, based on the description maybe some versioning issues with vscode extension dependencies? there was also some hickup changing some deps from bundled to external in paraglide, maybe this is similar.... |
Problem
Inlang – i18n supercharged
v1.29.4
can't seem to load a project that worked fine with major version release (v1.29.0
).I am getting the following error:
...and inlang commands do not work anymore, and instead log:
Expected behavior
Work as it did before.
Reproduction
Other information
The text was updated successfully, but these errors were encountered: