Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

being able to define module settings #19

Closed
Tracked by #2249
samuelstroschein opened this issue Feb 16, 2024 · 3 comments
Closed
Tracked by #2249

being able to define module settings #19

samuelstroschein opened this issue Feb 16, 2024 · 3 comments
Assignees

Comments

@samuelstroschein
Copy link
Member

samuelstroschein commented Feb 16, 2024

Context

Inlang apps should be able to offer non-devs the ability to change module settings.

Proposal

  1. Show module settings in the settings component settings web component for inlang apps monorepo#2249
  2. Use the module settingsSchema to generate a form that users can fill in and be validated against.

Pros

  • no code way to change module settings
  • less docs required for modules. the settingsSchema is the source of truth that is displayed in-app, making settings discoverable
@maige-app maige-app bot added the duplicate This issue or pull request already exists label Feb 16, 2024
@samuelstroschein samuelstroschein removed the duplicate This issue or pull request already exists label Feb 16, 2024
@samuelstroschein
Copy link
Member Author

cc @jannesblobel we talked about this

@samuelstroschein
Copy link
Member Author

samuelstroschein commented Feb 19, 2024

Insight on a call with @NilsJacobsen:

The flow is identical to rendering the rest of the settings by using the JSONSchema. Hence, build the regular settings UI automatically enables rendering module settings with [...project.installed.plugins, ...project.installed.lintRules].map((module) => module.settingsSchema)

@NilsJacobsen NilsJacobsen transferred this issue from opral/monorepo Apr 9, 2024
Copy link
Member

We can close this, as we decided to approach it like that.

@NilsJacobsen NilsJacobsen closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants