Open in Fink link does not include branch | Sherlock 🕵️♂️ #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The openInEditor command in the Sherlock IDE extension has been updated to change the title to "Sherlock: Open in Fink". Additionally, a new branch parameter has been added to the command callback function, allowing users to specify a branch when opening the editor. This change improves the usability and flexibility of the command.
This commit adds a new utility function called getCurrentBranch to the inlang/source-code/ide-extension/src/utilities/settings directory. The function retrieves the current branch of the git repository and allows for testing with functional code. This addition improves the functionality and flexibility of the IDE extension.
The openInEditor command in the Sherlock IDE extension has been refactored to use the openInFink function instead. This change improves the clarity and consistency of the codebase.
The openInEditor command in the Sherlock IDE extension has been refactored to use the openInFink function instead. This change improves the clarity and consistency of the codebase.
Refactor the openInEditor command in the Sherlock IDE extension to use the openInFink function instead. This improves codebase clarity and consistency.
The openInEditor command in the Sherlock IDE extension has been renamed to openInFink. This change improves codebase clarity and consistency.
🦋 Changeset detectedLatest commit: aab8f5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…s-not-include-branch
|
@felixhaeberle seems to be unrelated to the branch thing but a problem with finding the repo root, let me know if that helps or i should debug/ fix the pr directly |
|
@janfjohannes I basically copied the test setup from the test you wrote so it would be cool if you could look into it with the mocked repo state. |
|
@felixhaeberle looks like just your mocking setup was bad, please try to avoid mocks like hell. |
felixhaeberle
deleted the
felixhaeberle/sherl-25-open-in-fink-link-does-not-include-branch
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix SHERL-25
cc @janfjohannes can you please check why
test-symlinkisn't recognized as return value forrepo.getCurrentBranch()inmonorepo/inlang/source-code/ide-extension/src/utilities/settings/getCurrentBranch.test.ts
Line 36 in f6b654b