Detect if translation files have changed

[NiklasBuchfink]

Problem

• You are working on a branch refactor/api that is unrelated to UI translations
• Someone fixed a few lint reports on main
• You get notified that you need to update the translations in refactor/api

Why?
Compared to main, refactor/api now has new lint errors. This could be fixed by merging main into refactor/api, but I don't care about translations because I'm working on something completely different.

Proposal

Ninja needs to check if the branch contains updated translation files. Only if there are changes in this branch it makes sense to create a comment.

[linear]

NINJA-13 Detect if translation files have changed

[janfjohannes]

@niklas.buchfink also take into consideration the default merge that happens in github actions usually. as i understand the actions run on a simulated merge of the current branch into the basebranch, not on the tip of the branch they are configured on. in this scenario im not sure why there would be lint errors as the main branch merge would have the fixed translation. maybe your action does something not according to the configured merge strategy in github action?

[NiklasBuchfink]

@jan.johannes No merge is really simulated in Ninja. It just checks out the branches, collects all reports and compares if there are new ones in the branch.

[NiklasBuchfink]

Comparing the target to a merge simulation of the head with the head/target seems to make sense.

[NiklasBuchfink]

@jan.johannes I'm currently working on this. Can you elaborate how I can access the default merge. I would like to check this out and compare it with main.

[NiklasBuchfink]

Because of the pull_request_target. Since I can't comment without them, I have to merge them manually. I hope that the GitHub action can do this without a private key.