Add support for access logging #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 11, 2014 09:33
| @@ -9,5 +9,6 @@ | |||
| recipe 'master', 'Installs a Jenkins master' | |||
|
|
|||
| depends 'apt', '~> 2.0' | |||
| depends 'logrotate' | |||
There was a problem hiding this comment.
You probably want to put at least some version constraint on the logrotate cookbook to keep it from changing radically under you.
|
@rchekaluk Have you had a chance to review the comments from @someara and @smurawski? @opscode-cookbooks/ociv Also please review. |
|
I'm closing this now for inactivity. Please feel free to open again in the future. |
|
Added additional commits per the above review comments. |
|
@schisamo Unable to reopen this PR myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't currently a standard technique for enabling a Jenkins access log across the various installation methods that this cookbook supports:
This pull request adds two new attributes that provision a standardized access logging capability across the above installation methods:
See also https://wiki.jenkins-ci.org/display/JENKINS/Access+Logging