Properly handle binding to loopback on mixed IPV4/IPV6 systems #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postfix will correctly handle IPV4 and IPV6 interface logic. If we specify just 127.0.0.1 we break IPV6 systems
someara
pushed a commit
that referenced
this pull request
Jun 11, 2014
Signed-off-by: Sean OMeara <someara@opscode.com>
|
merged in e6b58b2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current issue with the cookbook is it specifies loopback in the main.cfg for the NICs to bind to, but it specifies the networks to just 127.0.0.1. In the current release postfix prefers the IPV6 stack, but we don't bind to the IPV6 loopback. End result is postfix doesn't work. If you don't specify the network entirely it will handle the config correctly internally. On systems with IPV4 only it will write out 127.0.0.1, and on dual stack environments you'll get both loopbacks. So now we can just specify the attribute for my networks as nil and let the daemon handle the logic. This same logic lets someone avoid writing out any attribute in the cookbook, which might be handy for other attributes
And while I'm in here I updated modes to strings and copyrights / e-mails for Chef Software vs. Opscode.