add chef exec command #22
Conversation
|
this addresses the 'chef exec' part of #18 needs specs and such |
| banner "Usage: chef exec SYSTEM_COMMAND" | ||
|
|
||
| def run(params) | ||
| ruby_engine = defined?(RUBY_ENGINE) ? RUBY_ENGINE : 'ruby' |
There was a problem hiding this comment.
I don't see where this is being used.
There was a problem hiding this comment.
yeah, removed where i was playing around with using that...
|
👍 super simple and gets the job done |
|
No real feedback, other than to say this is a feature I definitely want. |
| 'GEM_HOME' => ENV['GEM_HOME'], | ||
| 'GEM_PATH' => Gem.path.join(':'), | ||
| } | ||
| cmd = Mixlib::ShellOut.new( *params.clone, :env => env, :live_stream => STDOUT ) |
There was a problem hiding this comment.
Shouldn't we just exec for real here?
this is still /opt/chef/embedded/bin not the user's homedir tho
|
@danielsdeleo updated... |
| def run(params) | ||
| user_bin_dir = File.expand_path(File.join(Gem.user_dir, 'bin')) | ||
| env = { | ||
| 'PATH' => "#{user_bin_dir}:#{omnibus_embedded_bin_dir}:#{ENV['PATH']}", |
There was a problem hiding this comment.
Can we up-factor this, too, either a method that returns an Array or this String? I'd still like to do the shell-init thing and it'd be best to keep consistent between the two.
There was a problem hiding this comment.
just the PATH or also the other env vars?
There was a problem hiding this comment.
probably just the PATH, at least for now. I think if you want to go all-in on ChefDK as your ruby environment, it makes more sense to just disable any rvm or whatever rather than stomping on all the environment variables?
|
@danielsdeleo i went with an omnibus_env helper so you can get that from omnibus_env['PATH'], or have the other stuff available as well. don't think that'll hurt any and it makes the chef exec code completely trivial. |
|
👍 I was about to write this, then I saw it was already done. |
Add chef exec command to exec a command but with the environment variables overridden to bust out of any rvm/rbenv/chruby whatever environment and do everything relative to the embedded ruby and with all the omnibus stuff first in the path.