This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
exclude graphviz tags from berks tests #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # https://github.com/berkshelf/berkshelf/pull/1021 | ||
| :test_cmd => "bundle exec rspec --color --format progress spec/unit --tag ~hg && \ | ||
| # these are merged: | ||
| # https://github.com/berkshelf/berkshelf/pull/1021 (mercurial) |
There was a problem hiding this comment.
Looks like that got merged so we shouldn't need to exclude :hg any more. In the graphviz case, we need to either add graphviz to omnibus, or exclude graphviz from the test suite indefinitely.
|
The appropriate PR was merged into Berkshelf master |
| @@ -48,11 +48,12 @@ def components | |||
| component "berkshelf", | |||
| :base_dir => "berkshelf", | |||
| # For berks the real command to run is "bundle exec thor spec:ci" | |||
| # We can't run it right now since mercurial specs are included in the | |||
| # We can't run it right now since graphviz specs are included in the | |||
| # test suite by default. We will be able to switch to that command when | |||
| # this is merged: | |||
There was a problem hiding this comment.
This comment isn't technically correct, since merging that PR just gives us the option to exclude graphviz tests. We can just say "We will be able to switch to that command when/if graphviz is added to omnibus"
|
@danielsdeleo made things better |
|
Awesome! |
mcquin
added a commit
that referenced
this pull request
Apr 24, 2014
exclude graphviz tags from berks tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couples with: berkshelf/berkshelf#1163
@opscode/client-eng