Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chef 12 doesn't support symlinks to relative paths anymore #2580

Closed
slallema opened this issue Dec 9, 2014 · 0 comments · Fixed by #2623
Closed

Chef 12 doesn't support symlinks to relative paths anymore #2580

slallema opened this issue Dec 9, 2014 · 0 comments · Fixed by #2623
Assignees
@sersut
Labels
Status: Adopted An issue that is being worked on. Type: Bug Does not work as expected.
Milestone
12.0.2

Comments

@slallema
Copy link

slallema commented Dec 9, 2014

One must be able to create symlinks to relative paths such as :

link '/etc/lighttpd/conf-enabled/10-fastcgi.conf' do
  to '../conf-available/10-fastcgi.conf'
  link_type :symbolic
  owner 'root'
  group 'root'
end

With chef 11 this was working fine.

lrwxrwxrwx 1 root root 33 Dec  3 18:28 /etc/lighttpd/conf-enabled/10-fastcgi.conf -> ../conf-available/10-fastcgi.conf

With chef 12, the link created is :

lrwxrwxrwx 1 root root 31 Dec  9 10:33 /etc/lighttpd/conf-enabled/10-fastcgi.conf -> /conf-available/10-fastcgi.conf

After some investigation, I think that the commit b4cbc08 introduced that regression
@sersut sersut added this to the 12.0.1 milestone Dec 9, 2014
@sersut sersut modified the milestones: 12.0.1, 12.0.2 Dec 9, 2014
@sersut sersut self-assigned this Dec 10, 2014
@sersut sersut added the Bug label Dec 10, 2014
@sersut sersut mentioned this issue Dec 11, 2014
Closed
sersut pushed a commit that referenced this issue Dec 12, 2014
As #2580 summarizes, Link resource need to support relative paths in …
af20f1f 
…its 'to' attribute since one can create a symlink pointing to a relative location. This is useful if the directory that symlink resides in moves to a different place (e.g. mounting a disk on a separate location).

This commit preserves relative paths inside the "encode_path" method used by the link operations and expands relative paths in similar fashion when being used by file operations.
@sersut sersut mentioned this issue Dec 12, 2014
Merged
sersut pushed a commit that referenced this issue Dec 15, 2014
CHANGELOG information for #2580.
f2f9866
@thommay thommay added Type: Bug Does not work as expected. and removed Bug labels Jan 25, 2017
@chef chef locked and limited conversation to collaborators Nov 16, 2017
@tas50 tas50 added Status: Adopted An issue that is being worked on. and removed Status: Pull Request Submitted labels Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sersut sersut

Labels
Status: Adopted An issue that is being worked on. Type: Bug Does not work as expected.
Projects
None yet
Milestone
12.0.2
4 participants
@thommay @tas50 @sersut @slallema