Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHEF-3771] Fix spurious resource clone warnings #593

Merged
merged 4 commits into from Jan 17, 2013
Merged

Conversation

danielsdeleo
Copy link
Contributor

http://tickets.opscode.com/browse/CHEF-3694
http://tickets.opscode.com/browse/CHEF-3771

in Chef 10.18.0, a warning for resource cloning is erroneously emitted for every resource.

This PR fixes that and makes the warnings a bit nicer as well.

Example warning after patch:

[2013-01-17T09:24:04-08:00] WARN: Cloning resource attributes for directory[/var/lib/chef] from prior resource (CHEF-3694)
[2013-01-17T09:24:04-08:00] WARN: Previous directory[/var/lib/chef]: /tmp/chef-solo/cookbooks/chef-server/recipes/rubygems-install.rb:98:in `block in from_file'
[2013-01-17T09:24:04-08:00] WARN: Current  directory[/var/lib/chef]: /tmp/chef-solo/cookbooks/chef-server/recipes/rubygems-install.rb:123:in `from_file'

@seth
Copy link
Contributor

seth commented Jan 17, 2013

From a it looks like code that should work perspective: 👍

@danielsdeleo danielsdeleo merged commit 909c147 into 10-stable Jan 17, 2013
@sethvargo sethvargo deleted the CHEF-3771 branch July 3, 2013 03:33
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants