OHAI-507: GCE Ohai plugin update for GCE v1beta1 compatibility #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/ohai/plugins/gce.rb
adamedx
pushed a commit
that referenced
this pull request
Oct 10, 2013
OHAI-507: GCE Ohai plugin update for GCE v1beta1 compatibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving from #191. @paulrossman, can you look over the re-integration of dmi? @danielsdeleo, thanks for supporting dmi.
I've tested this on gce -- I don't see the gce attributes unless I run chef-client with sudo. Is this ok? @paulrossman, would you expect execution of ohai without sudo to not be able to fetch gce attributes?