Kill opscode-test and replace with simple chef-server-bootstrap. #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylercloke
force-pushed
the
tc/update-bootstrap
branch
from
487c9df
to
a2bede3
Compare
|
Will squash and update changelog on 👍 Also, will change the software definition once I donate the |
| # | ||
| # Author:: Tyler Cloke (<tyler@getchef.com>) | ||
| # Copyright:: Copyright (c) 2012-2014 Chef Software, Inc. | ||
| # License:: Apache License, Version 2.0 |
There was a problem hiding this comment.
Picky: if this is new, it should probably just be 2014.
|
👍 |
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| # Enable S3 asset caching | |||
| # ------------------------------ | |||
| use_s3_caching true | |||
| use_s3_caching false | |||
There was a problem hiding this comment.
Why was this set to false? That should always be true for Chef's omnibus projects.
tylercloke
force-pushed
the
tc/update-bootstrap
branch
2 times, most recently
from
4a1a540
to
e3e12d7
Compare
Updated bootstrap in a variety of ways. Most importantly, pulled in chef-server-bootstrap to replace opscode-test. This allows us to get rid of a variety of now deprecated ruby code, including: + opscode-test + opscode-billing + couchrest + opscode-shared + mixlib-* (still used by client) It also removed inserting the pivotal password on bootstrap, as this was pointless, since it isn't used internally, and the unhashed password is saved nowhere, so a user would have to regenerate the password anyway to use it.
tylercloke
force-pushed
the
tc/update-bootstrap
branch
from
e3e12d7
to
e2a5500
Compare
tylercloke
added a commit
that referenced
this pull request
Dec 9, 2014
Kill opscode-test and replace with simple chef-server-bootstrap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo
opscode-testhas turned into a minefield of unused code and deprecated ruby projects.The aspect
opscode-testthat is used is bootstrapping the initial superuser (solving the chicken and egg problem). Even this is mired in dependencies on old ruby repos that we want to deprecate but still depends on this code (mixlib-authentication, mixlib-authorization, opscode-billing, and opscode-shared to name a few).This pulls in the refactored chef-server-bootstrap repo that pulls out all of the above dependencies and just has a simple script for bootstrapping the superuser and global containers, killing all the above dependencies. Also review that repo just linked (its a pretty small repo). Will transfer ownership to Chef if we decide to merge this work.
New Build
Relevant work
https://github.com/tylercloke/chef-server-bootstrap
Deprecation Notes