Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace plain fetch with something else #29

Open
FabioRosado opened this issue Jun 17, 2022 · 0 comments
Open

Replace plain fetch with something else #29

FabioRosado opened this issue Jun 17, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@FabioRosado
Copy link
Member

For now using fetch is working okay, but after testing the websocket token, I've noticed that once we get a forbidden request from the server all we get as an error message was: Failed to fetch which is as useful as you would expect.

We probably should replace fetch with something more useful. The motivation behind that is that we have a way to keep errors in our state store and in the future we should present that to the user. So it would be good to get a lot more information why a request failed.

Useful things:

  • status code
  • message
  • any extra data that we can add to the state
@FabioRosado FabioRosado added the enhancement New feature or request label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant