Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-C does not kill in windows #1190

Open
iguyking opened this issue Oct 23, 2019 · 2 comments
Open

Ctrl-C does not kill in windows #1190

iguyking opened this issue Oct 23, 2019 · 2 comments

Comments

@iguyking
Copy link
Contributor

Description

Trying to kill session using powershell on windows can take several minutes to register the ctrl-c

Steps to Reproduce

opsdroid start (in a powershell window)
Hit control-c

Expected Functionality

opsdroid should shut down

Experienced Functionality

Can take several minutes then finally decide to shut down.

Versions

  • Opsdroid version: v0.16.0
  • Python version: 3.7.3
  • OS/Docker version: Windows 10

Configuration File

# Show welcome message
welcome-message: true

## Skill modules
skills:

  ## Dance (https://github.com/opsdroid/skill-dance)
  - name: dance

  ## Hello (https://github.com/opsdroid/skill-hello)
  - name: hello

  ## Loudnoises (https://github.com/opsdroid/skill-loudnoises)
  - name: loudnoises

  ## Seen (https://github.com/opsdroid/skill-seen)
  - name: seen

Additional Details

Any other details you wish to include such as screenshots, console messages, etc.

@jacobtomlinson
Copy link
Member

When hitting ctrl+c a bunch of things happen within opsdroid to gracefully shut down the process.

My guess here would be that something is taking a long time to shut down.

It seems like the signal handlers are attached differently in windows (or not at all). This may explain some of what is happening here. https://github.com/opsdroid/opsdroid/blob/master/opsdroid/core.py#L53

@vrashankraom
Copy link

For some updates of windows,ctrl+c wont eliminate windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants