Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If connectionstrings have a backslash in them, app crashes #34

Closed
waynebrantley opened this issue Feb 17, 2014 · 7 comments
Closed

If connectionstrings have a backslash in them, app crashes #34

waynebrantley opened this issue Feb 17, 2014 · 7 comments

Comments

@waynebrantley
Copy link

If connectionstrings have a backslash in them, like server\instance, it crashes. Using server\instance works.

@patHyatt
Copy link
Contributor

@waynebrantley Believe your last item was supposed to be

server\\instance

@waynebrantley
Copy link
Author

thanks

@NickCraver
Copy link
Member

Closing this out, this is global across most platforms...any string needs valid escaping or will cause oddities, I'm not sure it's worth putting effort into handling specifically. A more robust checking of all configs and clearer errors of all common mistakes is on the back burner, but more features need to go in first, since they'll add to the config pool.

@chriswedgwood
Copy link

"server\instance" allows the Servers to be monitored but in certain areas such as Server configuration of the instance the the node value passed is incorrectly. I've seen in other sql tools require you to enter instances as server_instance. I would be happy to work on this. I've actually never contributed to an open source project so am a bit confused about how to do this
thanks
Chris

@NickCraver
Copy link
Member

@Wedge1978 Do you have an example of a link that breaks? Admittedly, we don't have named instances here but it's probably a quick fix none the less.

@chriswedgwood
Copy link

If you click on one of the servers and then viewconfiguration

If the instance was TDC2SQL011\INS004 then the value that gets passed to
the controller is TDC2SQL011INS004 which is not recognised.

On 3 March 2014 11:28, Nick Craver notifications@github.com wrote:

@Wedge1978 https://github.com/wedge1978 Do you have an example of a
link that breaks? Admittedly, we don't have named instances here but it's
probably a quick fix none the less.

Reply to this email directly or view it on GitHubhttps://github.com//issues/34#issuecomment-36501741
.

@NickCraver
Copy link
Member

@chriswedgwood this is now fixed and tested in the new overhaul code, see 514bfcf

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants