Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Health / Liveness Endpoint #65

Open
mrueg opened this issue Jul 9, 2020 · 2 comments
Open

Health / Liveness Endpoint #65

mrueg opened this issue Jul 9, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@mrueg
Copy link
Contributor

mrueg commented Jul 9, 2020

It would be awesome if there were endpoints for health / liveness probes defined, (e.g. test if it can connect to k8s API) https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/

@mustafaakin
Copy link
Contributor

It's a good idea. However, testing whether it can connect to the API is not a good probe. If it cannot, it should be in crash-loop. However, readiness can be set after the pod performs the watch call to API. Watch is called once, then for labels, we get the objects. For clusters, that might not grant "read" permissions for all types (CRDs are not included by default) we ignore the error. So it gets trickier. What can be the solution?

@mustafaakin mustafaakin added the good first issue Good for newcomers label Aug 22, 2020
@bygui86
Copy link

bygui86 commented Nov 3, 2020

I suggest to include in the probes also a sort of connectivity check of all receivers.
For example, defining es, slack and stdout receivers:

  • check if ES connectivity is fine and works
  • check if slack push works
  • check if stdout file (/dev/stdout) exists and is usable (permissions?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants