Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Incorrect condition for error logging for webhook sink #70

Closed
sbrakl opened this issue Jul 22, 2020 · 0 comments · Fixed by #72
Closed

Incorrect condition for error logging for webhook sink #70

sbrakl opened this issue Jul 22, 2020 · 0 comments · Fixed by #72

Comments

@sbrakl
Copy link

sbrakl commented Jul 22, 2020

When using webhook to export Kubernetes event, if the webhook return 200, it logs it as error "not 200/201". Log severity is debug,error. This is due to incorrect condition at

pkg/sinks/webhook.go line 56

Condition should be treat all http status between [200-204] as success

if resp.StatusCode > 204 { 
...
}
@sbrakl sbrakl changed the title In correct condition for error for webhook Incorrect condition for error logging for webhook sink Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant