Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last-Modified format is invalid #360

Closed
nuttytree opened this issue Jul 24, 2023 · 5 comments
Closed

Last-Modified format is invalid #360

nuttytree opened this issue Jul 24, 2023 · 5 comments

Comments

@nuttytree
Copy link

After updating to version 3.11.3 from 3.11.2.1 (which added reading the Last-Modified header) we get error The format of value '05/18/2023 13:35:06 +00:00' is invalid and cannot get the latest configuration.

@mikechu-optimizely
Copy link
Contributor

Grrrr I can't believe I didn't wrap a proper test around the proper format of If-Modified-Since. Sounds like I also need e2e tests in there too.

I'm getting my PM to create a bug ticket.

@mikechu-optimizely
Copy link
Contributor

@nuttytree Would you mind taking a quick review of the above whenever you have a chance? Thanks! 👍

@nuttytree
Copy link
Author

Without digging to far into how that date is handled downstream it looks good. Only question is should it be stored as a string and converted back and forth between a DateTime and a string or just stored as a DateTime (keep in mind I have not dug into the code enough to see if there is maybe an obvious reason it should be this way)?

@mikechu-optimizely
Copy link
Contributor

Merged to master. I have 1 more bug fix before creating a patch release 3.11.4.

@mikechu-optimizely
Copy link
Contributor

Released 3.11.4 to NuGet.

Thanks for the help on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants