Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactivate Google GeoLocation API #56

Closed
4 tasks
kenodressel opened this issue Mar 19, 2020 · 6 comments
Closed
4 tasks

Reactivate Google GeoLocation API #56

kenodressel opened this issue Mar 19, 2020 · 6 comments
Assignees
@mauriceackel
Labels
enhancement New feature or request inprogress priority-high

Comments

@kenodressel
Copy link
Collaborator

kenodressel commented Mar 19, 2020 •
edited

  • Migrate Database (plz --> geolocations)
  • Verify that the website still works when we flip the feature flag
  • Verify that the firebase functions still works when we flip the feature flag
  • make the repo backwards compatible so that we can always go back to plz with out migration

The backwards compatibility is enforce by only allowing users to input a plz in the "askForHelp" form and the "offer-help" form.
@kenodressel kenodressel added the enhancement New feature or request label Mar 19, 2020
@felixmagnus felixmagnus mentioned this issue Mar 20, 2020
Closed
@mauriceackel mauriceackel self-assigned this Mar 20, 2020
@almereyda
Copy link

Without wanting to be rude, please consider using real geolocations instead of postal codes, only. They are flawed for geodata, and introduce many problems in maintaining the data set in the long run.

https://towardsdatascience.com/stop-using-zip-codes-for-geospatial-analysis-ceacb6e80c38

Please reconsider if this kind of backwards compatibility is needed, or if it wouldn't be better to keep the post code field, but introduce an additional geolocation.

@mauriceackel
Copy link
Member

This is exactly what we are planning to do regarding this issue.

@florianschmidt1994 florianschmidt1994 added invalid This doesn't seem right inprogress priority-high and removed invalid This doesn't seem right labels Mar 22, 2020
@mauriceackel mauriceackel mentioned this issue Mar 23, 2020
Closed
@tgraupne
Copy link
Member

@kenodressel @Maurice22 this can be closed, right?

@mauriceackel
Copy link
Member

Is the database migration fully done? If not, I would keep it open or create a new issue.

@tgraupne
Copy link
Member

Is the database migration fully done? If not, I would keep it open or create a new issue.

Good point, I am not sure. Could you follow up on that?

@tgraupne tgraupne changed the title Reactivate Google Maps Reactivate Google GeoLocation API Mar 25, 2020
@mauriceackel
Copy link
Member

Data migration finished. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauriceackel mauriceackel

Labels
enhancement New feature or request inprogress priority-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kenodressel @almereyda @florianschmidt1994 @tgraupne @mauriceackel