Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamp sorting not working while searching #89

Closed
mauriceackel opened this issue Mar 20, 2020 · 1 comment · Fixed by #98
Closed

Timestamp sorting not working while searching #89

mauriceackel opened this issue Mar 20, 2020 · 1 comment · Fixed by #98
Assignees
@janikga
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mauriceackel
Copy link
Member

mauriceackel commented Mar 20, 2020 •
edited by janikga

Filtered list should be sorted client-site if search is active.

Background: We can only sort by timestamp if we don't search in firebase. Hence, if the search flag is set, we need to do sorting locally.
@mauriceackel mauriceackel added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Mar 20, 2020
@janikga
Copy link
Collaborator

janikga commented Mar 21, 2020

example:

Screenshot 2020-03-21 at 15 41 07

will check it out :)

@janikga janikga self-assigned this Mar 21, 2020
@janikga janikga mentioned this issue Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janikga janikga

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug fix: add local sorting if location filter is active option26/quarantine-hero
2 participants
@janikga @mauriceackel