URL Detection

[krjackso]

I noticed in my app that the word "picture" is detected as a URL. After looking into it, I noticed that any phrase starting with "www" or "pic" will get detected as a URL, even though they are not valid URLs. Looking at the history, we used to use NSDataDetector but switched to a regex. Is there a compelling reason not to use NSDataDetector for this? The only test that fails using NSDataDetector is that "google.com" gets detected as a URL when the test does not want it to be (I would actually prefer it to be). Right now I am running with my fork that uses NSDataDetector until this can be resolved.

[polqf]

Hi @krjackso, I am sorry for the issue, we should take a look at the regex for the urls. The reason why we switched from NSDataDetector to regex is that data detector is 2x more expensive.

See #40 (comment)

Seems like NSDataDetector is slower than a custom Regex (2x the time)... Maybe we should move to a regex for the URLs?

[krjackso]

Yeah URL regexes are a real pain :) Perhaps a decent compromise would be opening up the RegexParser so that we can override the different types of detectors if we need them to be different? The other thing I like about using NSDataDetector for URLs is it will be consistent with other things using it to detect links which will be important for my users who are mostly coming from the bundled iOS apps.

[polqf]

Yep, i like the idea, but in order to fix and add tests for it, I would like to know first which text is being detected as url, and it is not. Even if we open the Regex parser, there should be a default regex.

[Abdul-Moiz]

Hi, I am still detecting "picture." highlighted as a URL.

This issue is still not resolved.

[polqf]

Not able to reproduce, closing...