Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseStorage.get_best_trial fails when values include None #123

Closed
g-votte opened this issue Jun 7, 2018 · 0 comments
Closed

BaseStorage.get_best_trial fails when values include None #123

g-votte opened this issue Jun 7, 2018 · 0 comments

Comments

@g-votte
Copy link
Member

g-votte commented Jun 7, 2018

As (1) the current implementation accept object function's returning None and (2) None value is not filtered when getting all completed trials, BaseStorage.get_best_trial fails to calculate min when values include None.
@g-votte g-votte closed this as completed Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@g-votte