-
-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new parameter to TPESampler
#2385
Comments
I want to point out that currently, |
TPE supports independent sampling by default. So, it is inappropriate to add By the way, if the number of previous trials is smaller than |
I'd like to discuss the name of the argument to be added. |
@HideakiImamura Thank you for your suggestion. I agree with you on the point that |
This issue has not seen any recent activity. |
This issue was closed automatically because it had not seen any recent activity. If you want to discuss it, you can reopen it freely. |
Motivation
Currently, there is no argument to pass
independent_sampler
inTPESampler
but in the future, it may be useful to users and may provide flexibility if we can add something as an argument to it like other samplers.Description
In current implementation, There is a variable
random_sampler
there inTPESampler
, whoseafter_trial
method is called when a fallback occurs. Other samplers useindependent_sampler
by default initialized withRandomSampler
, so in both the cases the performance is same if no argument is passed. However, if we includeindependent_sampler
inTPESampler
there will be flexibility when a new sampler can be used in place ofRandomSampler
(such as Sobol, issue #1797 ).Additional context (optional)
This is discussion of
independent_sampler
in continuation of PR #2376. Let me know your views on this!The text was updated successfully, but these errors were encountered: