Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate the length of valued of set_user_attr. #2522

Closed
PhilipMay opened this issue Mar 25, 2021 · 3 comments
Closed

Truncate the length of valued of set_user_attr. #2522

PhilipMay opened this issue Mar 25, 2021 · 3 comments
Labels
feature Change that does not break compatibility, but affects the public interfaces.

Comments

@PhilipMay
Copy link
Contributor

When I want to log long strings (like exceptions with stacktrace) as an user_attr the content might get very long. If value is above the length of 2048 characters an exception is thrown. This should be avoided by truncation and maybe logging a warning.

There might be other locations where the same problem might happen. Like in set_system_attr. This can be done on trial and study layer. That needs to be analysed.
@PhilipMay PhilipMay added the feature Change that does not break compatibility, but affects the public interfaces. label Mar 25, 2021
@y0z
Copy link
Member

y0z commented Mar 25, 2021 •
edited

Hi. I think this limitation problem has already been fixed in #2395.

@PhilipMay
Copy link
Contributor Author

Ok - I will check.

@PhilipMay
Copy link
Contributor Author

Works. Thanks - I am closing this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Change that does not break compatibility, but affects the public interfaces.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PhilipMay @y0z