Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include DaskStorage in tests/storages_tests/test_storages.py #4175

Closed
jrbourbeau opened this issue Nov 15, 2022 · 0 comments · Fixed by #4176
Closed

Include DaskStorage in tests/storages_tests/test_storages.py #4175

jrbourbeau opened this issue Nov 15, 2022 · 0 comments · Fixed by #4176
Labels
code-fix Change that does not change the behavior, such as code refactoring.

Comments

@jrbourbeau
Copy link
Contributor

Motivation

Following up on #2023 (review), it would be good to have DaskStorage hook into the existing storage tests in tests/storages_tests/test_storages.py.

Suggestion

I'll plan to open a PR for this, but wanted to open an issue so we don't loose track of it.

Additional context (optional)

No response
@jrbourbeau jrbourbeau added the code-fix Change that does not change the behavior, such as code refactoring. label Nov 15, 2022
@jrbourbeau jrbourbeau mentioned this issue Nov 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add DaskStorage to existing storage tests jrbourbeau/optuna
1 participant
@jrbourbeau