Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions versions to use Node 20 #5242

Closed
3 of 4 tasks
Alnusjaponica opened this issue Feb 10, 2024 · 4 comments · Fixed by #5367
Closed
3 of 4 tasks

Update GitHub Actions versions to use Node 20 #5242

Alnusjaponica opened this issue Feb 10, 2024 · 4 comments · Fixed by #5367
Labels
feature Change that does not break compatibility, but affects the public interfaces.

Comments

@Alnusjaponica
Copy link
Collaborator

Alnusjaponica commented Feb 10, 2024

Motivation

GitHub official encourages to update GitHub Actions to use Node 20 in their blog posts, as Node 16 has reached its end of life.

Description

We need to

  • List up all the files in optuna/ repositories which need updating,
  • Carefully examine the change logs of GitHub Actions and describe how updates effects on current CI,

to confirm that it's safe to update these actions before you actually do it. Please refer to #4165 and related PR (e.g. #4208) for reference. Then,

  • Update actions/checkout from v3 to v4.
  • Update actions/setup-python from v4 to v5.
@Alnusjaponica Alnusjaponica added the feature Change that does not break compatibility, but affects the public interfaces. label Feb 10, 2024
@HarshitNagpal29
Copy link
Contributor

can you assign this issue to me??

@nzw0301
Copy link
Member

nzw0301 commented Feb 11, 2024

@HarshitNagpal29 Thank you for your comment. You can work on this issue since no one is assigned to this issue and https://github.com/optuna/optuna/blob/master/CONTRIBUTING.md does not have such a rule.

@Alnusjaponica
Copy link
Collaborator Author

Alnusjaponica commented Feb 13, 2024

@nzw0301 Thanks for your comments
@HarshitNagpal29 Thank you for your suggestion. Feel free to work on it. However, please note that we still need to list all the files that need updating and examine how the update affects the current CI in this issue.

@HarshitNagpal29
Copy link
Contributor

However, please note that we still need to list all the files that need updating and examine how the update affects the current CI in this issue.

@Alnusjaponica Ok sir, I will try to do that, I was thinking of updating all the files once and then try to check how each file is behaving, while CI run check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Change that does not break compatibility, but affects the public interfaces.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants