Task/oracle test #170
Merged
Task/oracle test #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoncoding
force-pushed
the
task/oracle-test
branch
from
e97662c
to
59aff6c
Compare
aparnakr
reviewed
Aug 17, 2020
aparnakr
reviewed
Aug 17, 2020
| await oracle.setAssetToCtoken(bat.address, cBat.address); | ||
|
|
||
| // update compound oracle price for BAT | ||
| const batPrice = '777857500000000'; |
There was a problem hiding this comment.
Is it possible to use ganache fork for this and also test with mainnet data? (Also these tests will probs change since we need to use a different oracle now right?)
There was a problem hiding this comment.
This is the data I copied from mainnet, for unit tests I think it's okay that we just hardcode the value, because we don't have existing cicd workflow to run ganache fork now.
aparnakr
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contract Changes
CompoundOracleInterfaceandOracleInterface:CompoundOracleInterfaceis the oneOracle.soluse to interact with compound v1 oracle, andOracleInterfaceis just the interface forOracle.solMockCompoundOracleandMockOracleaccordingly, useMockCompoundOracleinOracle's unit test.OptionsContract.solfromcompoundOracletooracleOptionExchangeinOptionsContract, declare that variable inOtoken, which is the only one using it.