Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing tests skip some features #86

Open
ageorgou opened this issue Jul 11, 2019 · 1 comment
Open

Parsing tests skip some features #86

ageorgou opened this issue Jul 11, 2019 · 1 comment
Labels

Comments

@ageorgou
Copy link
Contributor

The parser tests for some ATF features are missing meaningful assertions and therefore pass trivially.

This is because these tests were initially skipped while the relevant features were not supported, but no assertions were provided when they were reenabled.

The features in question and corresponding tests in test_atfparser.py are:

Feature Test functions
#key test_key_protocol, test_double_equals_in_key_protocol, test_many_equals_in_key_protocol, test_empty_key_in_key_protocol
use mylines test_mylines_protocol
use lexical test_lexical_protocol
#lemmatizer test_lemmatizer_protocol
={ test_line_equalsbrace
@ageorgou ageorgou added the bug label Jul 11, 2019
@rillian
Copy link
Contributor

rillian commented Jul 12, 2019

Since #85 these tests are marked as explicit skips again. They should be updated once there's model support for the missing features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants