Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property not passed through all the way #332

Closed
romain-grecourt opened this issue Dec 2, 2020 · 2 comments · Fixed by #568
Closed

Property not passed through all the way #332

romain-grecourt opened this issue Dec 2, 2020 · 2 comments · Fixed by #568
Assignees
Labels
bug Something isn't working cli P2
Milestone

Comments

@romain-grecourt
Copy link
Contributor

When passing -Dmaven.repo.local to the helidon-cli with a fresh repository, some of the output is not filtered.
It seems this indicates that the property is not passed through on some of the Maven invocation(s).

Steps to reproduce:

mv ~/.m2/repository/io/helidon ~/.m2/repository/io/helidon.bck
rm -rf /tmp/repo
helidon dev -Dmaven.repo.local=/tmp/repo

This happens with all variants of the cli (native, plain etc.)

@romain-grecourt romain-grecourt added this to the 2.1.3 milestone Dec 2, 2020
@barchetta barchetta added bug Something isn't working P2 labels Jan 15, 2021
@romain-grecourt romain-grecourt modified the milestones: 2.1.3, 3.0.0 Feb 22, 2021
@batsatt
Copy link
Contributor

batsatt commented Nov 30, 2021

This can be reproduced with the local snapshot build using the following to execute helidon dev:

rm -rf /tmp/repo && \
mkdir -p /tmp/repo/io/helidon/ && \
cp -r ~/.m2/repository/io/helidon/build-tools/ /tmp/repo/io/helidon/build-tools/ && \
helidon dev --clean -Dmaven.repo.local=/tmp/repo --current

Passing the maven.repo.local property through does not fix the issue. It is likely this is just a more complex case for DevCommand.TerminalModeOutput to handle; I will look at this next.

@batsatt
Copy link
Contributor

batsatt commented Dec 1, 2021

Download progress output occurs during the application build phase because the repo starts off empty and our plugin dependencies still need to be resolved. DevCommand.TerminalModeOutput has been updated to suppress these messages during the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants