You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The project name is only important for the generated directory name.
The issue is that when in interactive mode with helidon init, it is easy to change one value and not the other, resulting in behavior that violates the principle of least surprise. For example, using "foo" as the project name and accepting the default for artifact id will create a directory name "foo" but the artifact id, jar name, docker image name, etc. will all be based on the default.
Removing support for project name is the cleanest way of avoiding this issue:
Use the artifactId value for the directory name
Add a warning if --name is supplied saying that it will be unused
Add a comment in the generated user config saying that default.project.name is only used for v1
Note that artifactId will now be required and an exception will be thrown if there is no valid value for it.
It will replace the statement below inside ArchetypeEngineV2.
StringprojectName = requireNonNull(context.lookup(PROJECT_NAME), "project name is null").asString();
The text was updated successfully, but these errors were encountered:
ArchetypeEngineV2.generate() must be updated to use artifactId for the output directory.
IntegrationTestMojo.processIntegrationTest() must be updated to stop adding the name.
We currently have support for two different "names" with identical default values in the user config:
The project name is only important for the generated directory name.
The issue is that when in interactive mode with
helidon init
, it is easy to change one value and not the other, resulting in behavior that violates the principle of least surprise. For example, using"foo"
as the project name and accepting the default for artifact id will create a directory name"foo"
but the artifact id, jar name, docker image name, etc. will all be based on the default.Removing support for project name is the cleanest way of avoiding this issue:
artifactId
value for the directory name--name
is supplied saying that it will be unuseddefault.project.name
is only used for v1Note that
artifactId
will now be required and an exception will be thrown if there is no valid value for it.It will replace the statement below inside ArchetypeEngineV2.
The text was updated successfully, but these errors were encountered: