Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shutdown hooks in native-image #520

Conversation

romain-grecourt
Copy link
Contributor

@romain-grecourt romain-grecourt commented Oct 6, 2021

Fix shutdown hooks in native-image

Also fixed:

  • Fixed doubled newlines when printing error output in the dev command
  • Ignore exit code when process exited because of a shutdown

Fix doubled newlines when printing error output in the dev command
Ignore exit code when process exited because of a shutdown
@romain-grecourt romain-grecourt added this to the 2.3.0 milestone Oct 6, 2021
@romain-grecourt romain-grecourt changed the title Fix shutdown hook in native-image Fix shutdown hooks in native-image Oct 6, 2021
@romain-grecourt romain-grecourt merged commit b3f6d60 into helidon-io:helidon-2.x Oct 6, 2021
@romain-grecourt romain-grecourt deleted the native-image-shutdown-hooks branch October 6, 2021 03:51
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romain-grecourt romain-grecourt mentioned this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants