Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helidon:native-image -H:Name needs to be after -jar #700

Closed
romain-grecourt opened this issue Apr 13, 2022 · 3 comments · Fixed by #707
Closed

helidon:native-image -H:Name needs to be after -jar #700

romain-grecourt opened this issue Apr 13, 2022 · 3 comments · Fixed by #707
Labels
bug Something isn't working
Milestone
2.3.4

Comments

@romain-grecourt
Copy link
Contributor

When finalName and jarFile are different, the order of -H:Name matters, it needs to be after -jar ${jarFile} for it to be taken into account by native-image.

native-image -H:Name=foo -jar target/java-test-1.0.0-SNAPSHOT.jar
GraalVM Native Image: Generating 'java-test-1.0.0-SNAPSHOT'...
native-image -jar target/java-test-1.0.0-SNAPSHOT.jar -H:Name=Foo
GraalVM Native Image: Generating 'Foo'...
@romain-grecourt romain-grecourt added the bug Something isn't working label Apr 13, 2022
@romain-grecourt
Copy link
Contributor Author

See #691

@andrejusc
Copy link

Will you try to follow here with some Graal folks to clarify direction of this bug fixing?

@barchetta barchetta added this to the 2.3.4 milestone May 4, 2022
romain-grecourt added a commit to romain-grecourt/helidon-build-tools that referenced this issue May 4, 2022
@romain-grecourt
Add -H:Name after -jar
f31ee39 
Fixes helidon-io#700
@romain-grecourt romain-grecourt mentioned this issue May 4, 2022
Merged
romain-grecourt added a commit that referenced this issue May 5, 2022
@romain-grecourt
Add -H:Name after -jar (#705)
4ca308d 
Fixes #700
@andrejusc
Copy link

Verified latest 2.x Snapshot build - now it respects properly both present <finalName> and <jarFile> elements' values.

romain-grecourt added a commit to romain-grecourt/helidon-build-tools that referenced this issue May 5, 2022
@romain-grecourt
Add -H:Name after -jar (helidon-io#705)
03eaa5e 
Fixes helidon-io#700
@romain-grecourt romain-grecourt mentioned this issue May 5, 2022
Merged
romain-grecourt added a commit that referenced this issue May 5, 2022
@romain-grecourt
Add -H:Name after -jar (#705) (#707)
c080bbb 
Fixes #700
romain-grecourt added a commit that referenced this issue May 5, 2022
@romain-grecourt
Update changelog 3.x (#708)
11bad81 
* Add -H:Name after -jar (#705)

Fixes #700

* Add entry for 2.3.4 in the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.3.4
Development

Successfully merging a pull request may close this issue.

Add -H:Name after -jar (#705) romain-grecourt/helidon-build-tools
3 participants
@romain-grecourt @barchetta @andrejusc