Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of filters and mappers when converting MP to Helidon config #1802

Closed
rlubke opened this issue May 14, 2020 · 0 comments
Closed

Allow use of filters and mappers when converting MP to Helidon config #1802

rlubke opened this issue May 14, 2020 · 0 comments

Comments

@rlubke
Copy link
Contributor

rlubke commented May 14, 2020

Environment Details

  • Helidon Version: 2.0.0-SNAPSHOT
  • Helidon MP
  • JDK version: 11.0.7
  • OS: Mac OS 10.15.4
  • Docker version (if applicable): N/A

Problem Description

The issue is that gRPC MP and SE client share configuration, which means that they both ultimately use Helidon SE Config, and depend on object-mapping to read complex config structure into a POJO that describes gRPC channel.

However, because we start everything up from MP world, we are loading MpConfig and converting it to Config. In the process, mapper services get disabled and this conversion doesn’t work any longer. However, if we comment out the line below within MpConfig.toHelidonConfig() that disables them, everything works fine:

io.helidon.config.Config.Builder builder = io.helidon.config.Config.builder()
                .disableEnvironmentVariablesSource()
                .disableSystemPropertiesSource()
                //.disableMapperServices()
                .disableCaching()
                .disableParserServices()
                .disableFilterServices(); 

Response from @tomas-langer:

The intention of the change was to get the same configuration as we have in MP. But that can never be the case.
So I think we can enable mappers and filters (to allow use of advanced Helidon SE features if developers want to)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant