Fixes NPE in RequestRouting#canonicalize()

[ljnelson]

Signed-off-by: Laird Nelson laird.nelson@oracle.com

[ljnelson]

This PR makes the RequestRouting#canonicalize(String) method handle null and empty inputs in an effort to solve one of the issues brought up in #1069.

[dansiviter]

Two things:

• Should this not have a unit test to avoid issues going forward?
• Any reason why not a more fail-fast approach which is easier to read:

    private static String canonicalize(String p) {
        if (p == null || p.isEmpty() || p.equals("/")) {
            return "/";
        }
        int lastCharIndex = p.length() - 1;
        if (p.charAt(lastCharIndex) == '/') {
            return p.substring(0, lastCharIndex);
        }
        return p;
    }

I'm interested to know what the benefit is of indenting more or delaying the return of the method when you already know the result.