Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing several rollback-related issues #1146

Merged
merged 7 commits into from
Dec 3, 2019
Merged

Addressing several rollback-related issues #1146

merged 7 commits into from
Dec 3, 2019

Conversation

ljnelson
Copy link
Member

Signed-off-by: Laird Nelson laird.nelson@oracle.com

@ljnelson ljnelson added task To do P3 labels Nov 14, 2019
@ljnelson ljnelson self-assigned this Nov 14, 2019
@ljnelson ljnelson mentioned this pull request Nov 27, 2019
Closed
@ljnelson ljnelson added this to In Progress in Backlog Nov 27, 2019
paulparkinson
paulparkinson previously approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@paulparkinson paulparkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went through every file/change as well as background email - looks good as-is

@ljnelson
Copy link
Member Author

@paulparkinson you are the guy. Thanks and happy Thanksgiving.

@ljnelson ljnelson mentioned this pull request Dec 2, 2019
Closed
@ljnelson ljnelson marked this pull request as ready for review December 2, 2019 04:37
@ljnelson
Addressing several rollback-related issues
065c948 
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson
Interim squashable commit; fixed checkstyle and spotbugs issues
390a728 
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson
Fixing H2-in-memory related issues. Squashable commit.
19c60b5 
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson
Corrected fallout from misreading of EntityManager#close(); interim s…
9d5d8ca 
…quashable commit

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson
Interim squashable commit
1637409 
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson
Interim squashable commit; more rollback tests
c097fd3 
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson
Interim squashable commit. Simplifies JpaTransactionScopedEntityManag…
615479d 
…er-related logic.

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson
Copy link
Member Author

ljnelson commented Dec 2, 2019

@paulparkinson assuming I haven't screwed up my rebase could you kindly re-approve this?

@paulparkinson
Copy link
Contributor

yep, looks unbroken :)

@ljnelson ljnelson merged commit f5e1cc5 into helidon-io:master Dec 3, 2019
Backlog automation moved this from In Progress to Closed Dec 3, 2019
ljnelson added a commit that referenced this pull request Dec 5, 2019
@ljnelson
Addressing several rollback-related issues (#1146) (#1189)
efe1fd3 
Addresses several JPA rollback-related issues.

(cherry picked from commit f5e1cc5)

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson ljnelson mentioned this pull request Dec 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulparkinson paulparkinson paulparkinson approved these changes

Assignees

@ljnelson ljnelson

Labels
P3 task To do
Projects
Backlog
  
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ljnelson @paulparkinson