Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed requirements on container-managed persistence units which can now be resource-local #1243

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Relaxed requirements on container-managed persistence units which can now be resource-local #1243

merged 2 commits into from
Dec 17, 2019

Conversation

ljnelson
Copy link
Member

Signed-off-by: Laird Nelson laird.nelson@oracle.com

… now be resource-local

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson ljnelson self-assigned this Dec 17, 2019
@ljnelson ljnelson added this to In Progress in Backlog Dec 17, 2019
@ljnelson
Copy link
Member Author

See #1242. Thanks to @mattjlewis for the original issue report.

paulparkinson
paulparkinson previously approved these changes Dec 17, 2019
Copy link
Contributor

@paulparkinson paulparkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe call it "resourceLocalPersistenceUnitWarning" rather than "resourceLocalPersistenceUnitDiscouraged" but no biggie :) Looks good.

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson
Copy link
Member Author

Done; thanks @paulparkinson; kindly re-approve?

@ljnelson ljnelson merged commit 8bd9ae1 into helidon-io:master Dec 17, 2019
Backlog automation moved this from In Progress to Closed Dec 17, 2019
ljnelson added a commit that referenced this pull request Dec 18, 2019
… now be resource-local (#1243).  Cherry-picked 8bd9ae1. (#1245)

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants