Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permits non-XA DataSources to take part in JTA transactions #1316

Merged
merged 9 commits into from
Jan 31, 2020
Merged

Permits non-XA DataSources to take part in JTA transactions #1316

merged 9 commits into from
Jan 31, 2020

Conversation

ljnelson
Copy link
Member

This PR allows "ordinary" javax.sql.DataSource implementations (such as those served up by the Hikari connection pool) to participate in JTA transactions.

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Copy link
Contributor

@paulparkinson paulparkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in call, etc. this looks good...

@ljnelson ljnelson marked this pull request as ready for review January 31, 2020 18:32
@ljnelson ljnelson merged commit 5d039a7 into helidon-io:master Jan 31, 2020
Backlog automation moved this from In Progress to Closed Jan 31, 2020
@ljnelson ljnelson deleted the jta-data-source-work branch January 31, 2020 18:36
ljnelson added a commit that referenced this pull request Feb 19, 2020
* Permits non-XA DataSources to take part in JTA transactions (#1316)

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>

* Fixing copyright issues (#1337)

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>

* Fixes an issue with multiple persistence units. (#1342)

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>

* Added more JPA tests (#1355)

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>

* Hopefully fixes apparently intermittent build errors experienced only on Wercker-built master (#1366)

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>

* Interim squashable commit; removes post-JDK 1.8 java.sql.Connection methods

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>

* Interim squashable commit; fixes checkstyle issues

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>

* Interim squashable commit; fixes copyright issues

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>

* Interim squashable commit; removed JDK 9+ methods from DelegatingConnection.java

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants