Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple jandex.idx files on the classpath #1318

Merged
merged 3 commits into from
Jan 23, 2020
Merged

Support multiple jandex.idx files on the classpath #1318

merged 3 commits into from
Jan 23, 2020

Conversation

tjquinno
Copy link
Member

Addresses issue #1304

These changes cause the OpenAPI annotation processing to handle all jandex.idx files that appear on the class path, not just the first one encountered.

The PR also adds a test that approximates this use case.

@tjquinno tjquinno added bug Something isn't working MP open-api P1 labels Jan 22, 2020
@tjquinno tjquinno added this to the 1.4.2 milestone Jan 22, 2020
@tjquinno tjquinno requested a review from batsatt January 22, 2020 21:56
@tjquinno tjquinno self-assigned this Jan 22, 2020
@tjquinno tjquinno added this to In Progress in Backlog Jan 22, 2020
batsatt
batsatt previously approved these changes Jan 22, 2020
Copy link
Contributor

@batsatt batsatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjquinno tjquinno added the 1.x Issues for 1.x version branch label Jan 23, 2020
@tjquinno tjquinno merged commit 7b8c716 into helidon-io:helidon-1.x Jan 23, 2020
Backlog automation moved this from In Progress to Closed Jan 23, 2020
@tjquinno tjquinno deleted the multi-jandex branch January 23, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Issues for 1.x version branch bug Something isn't working MP open-api P1
Projects
Backlog
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants