Adds Config into MediaSupport#builder() method #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
ljnelson
changed the title
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
romain-grecourt
previously approved these changes
Feb 19, 2020
tomas-langer
requested changes
Feb 19, 2020
media/common/src/main/java/io/helidon/media/common/MediaSupport.java
Outdated
Show resolved
Hide resolved
media/common/src/main/java/io/helidon/media/common/MediaSupport.java
Outdated
Show resolved
Hide resolved
media/common/src/main/java/io/helidon/media/common/MediaSupport.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
|
@ljnelson Can you add a config key for registering the defaults ? |
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
|
Done |
tomas-langer
approved these changes
Feb 19, 2020
romain-grecourt
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laird Nelson laird.nelson@oracle.com