Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SingleJust + TCK #1410

Merged
merged 5 commits into from
Feb 21, 2020
Merged

Conversation

akarnokd
Copy link
Collaborator

Improve the implementation of io.helidon.common.reactive.SingleJust to conform the Reactive Streams specification and add a TCK test for it as well.

@akarnokd
Copy link
Collaborator Author

On a related note, mvn validate -Pcheckstyle keeps failing locally because the class Ascii.java contains @author tags. I'm on Windows with IntelliJ 2019.3.x btw.

@akarnokd akarnokd closed this Feb 19, 2020
@akarnokd akarnokd reopened this Feb 19, 2020
A commit to master removed the reactor version reference in the meantime.
@danielkec danielkec merged commit 9287833 into helidon-io:master Feb 21, 2020
@akarnokd akarnokd deleted the SingleJustRework branch February 22, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants