Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade netty to 4.1.45 #1425

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Upgrade netty to 4.1.45 #1425

merged 1 commit into from
Feb 24, 2020

Conversation

tomas-langer
Copy link
Member

Upgrade Netty to same version we have in master

@tomas-langer tomas-langer added the 1.x Issues for 1.x version branch label Feb 21, 2020
@tomas-langer tomas-langer added this to the 1.4.2 milestone Feb 21, 2020
@tomas-langer tomas-langer self-assigned this Feb 21, 2020
@aseovic
Copy link
Collaborator

aseovic commented Feb 24, 2020

You should also make sure that we don't pull in multiple versions of Netty via gRPC dependency. Basically, we need to upgrade to grpc-java version that depends on Netty 4.1.45 at the same time, which means bumping grpc-java to 1.27.1 (the latest) in both 1.x and 2.0 branches.

@tomas-langer tomas-langer merged commit 869df21 into helidon-io:helidon-1.x Feb 24, 2020
@tomas-langer tomas-langer deleted the netty-upgrade-1.x branch February 24, 2020 09:23
@tomas-langer
Copy link
Member Author

Just read @aseovic comment...

@tomas-langer
Copy link
Member Author

Will create another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

Assignees

@tomas-langer tomas-langer

Labels
1.x Issues for 1.x version branch
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomas-langer @aseovic @barchetta