Prometheus format problems #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iolation that can be flagged by tools with validation enabled. This can happen for metrics with same name and different tags. We now keep track of TYPE and HELP lines added to format to avoid repetition.
tjquinno
reviewed
Feb 21, 2020
metrics2/metrics2/src/main/java/io/helidon/metrics/MetricsSupport.java
Outdated
Show resolved
Hide resolved
metrics2/metrics2/src/test/java/io/helidon/metrics/MetricsSupportTest.java
Show resolved
Hide resolved
metrics2/metrics2/src/main/java/io/helidon/metrics/MetricsSupport.java
Outdated
Show resolved
Hide resolved
tjquinno
approved these changes
Feb 21, 2020
spericas
added a commit
to spericas/helidon
that referenced
this pull request
Feb 24, 2020
…ELP lines in Prometheus format as this is a violation that can be flagged by tools with validation enabled. This can happen for metrics with same name and different tags. We now keep track of TYPE and HELP lines added to format to avoid repetition.
spericas
added a commit
that referenced
this pull request
Feb 25, 2020
…in Prometheus format as this is a violation that can be flagged by tools with validation enabled. This can happen for metrics with same name and different tags. We now keep track of TYPE and HELP lines added to format to avoid repetition. (#1440)
akarnokd
pushed a commit
to akarnokd/helidon
that referenced
this pull request
Feb 26, 2020
…ELP lines in Prometheus format as this is a violation that can be flagged by tools with validation enabled. This can happen for metrics with same name and different tags. We now keep track of TYPE and HELP lines added to format to avoid repetition. (helidon-io#1440)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not repeat LINE and HELP lines in Prometheus format as this is a violation that can be flagged by tools with validation enabled. This can happen for metrics with same name and different tags. We now keep track of TYPE and HELP lines added to format to avoid repetition.