Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement ConcatPublisher + TCK tests #1452

Merged
merged 4 commits into from
Mar 2, 2020
Merged

Reimplement ConcatPublisher + TCK tests #1452

merged 4 commits into from
Mar 2, 2020

Conversation

akarnokd
Copy link
Collaborator

Reimplement io.helidon.common.reactive.ConcatPublisher so it works as a properly reusable Flow.Publisher.

Fresh start due to master changes.

@akarnokd akarnokd mentioned this pull request Feb 27, 2020
Closed
@akarnokd
Copy link
Collaborator Author

Spotbugs doesn't like if I extend AtomicInteger because it is marked as Serializable and will cascade it everywhere even though Flow is not meant to be serialized at all.

@romain-grecourt
Copy link
Contributor

You can add an exclusion, either with an xml file, or using SuppressFBWarnings

@danielkec danielkec added the reactive Reactive streams and related components label Mar 2, 2020
@danielkec danielkec self-assigned this Mar 2, 2020
@danielkec danielkec merged commit 000d470 into helidon-io:master Mar 2, 2020
@akarnokd akarnokd deleted the ConcatPublishReimplement branch March 2, 2020 14:36
@danielkec danielkec added 2.x Issues for 2.x version branch and removed 2.x Issues for 2.x version branch labels Mar 2, 2020
@danielkec danielkec added this to the 2.0.0 milestone Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkec danielkec danielkec approved these changes

Assignees

@danielkec danielkec

Labels
reactive Reactive streams and related components
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akarnokd @romain-grecourt @danielkec