Support multiple apps in OpenAPI document #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjquinno
changed the title
…tons because they come from JaxRsCdiExtension in the server component which already provides instances
tjquinno
changed the title
…on of synthetic apps
… the JaxRsApplication already has an app instance (and therefore we do not need to instantiate the class)
tomas-langer
requested changes
Mar 17, 2020
microprofile/openapi/src/main/java/io/helidon/microprofile/openapi/MPOpenAPIBuilder.java
Outdated
Show resolved
Hide resolved
microprofile/openapi/src/main/java/io/helidon/microprofile/openapi/MPOpenAPIBuilder.java
Outdated
Show resolved
Hide resolved
tomas-langer
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1288
The SmallRye OpenAPI annotation scanning does not correctly handle multiple applications in the server. To deal with this, the Helidon MP layer:
(Because OpenAPI is also supported in SE this PR includes some changes in SE to enhance the contract of
OpenAPISupportand its builder. Functionally, SE is unaffected by this change.)To locate the apps, these revised Helidon MP OpenAPI layer uses the pre-existing JaxRsCdiExtension which harvests not only annotated apps but also ones registered programmatically.
There are a few changes to the MP server component so code that creates a
JaxRsApplicationcan indicate if it's a synthetic application being represented. This is useful because the OpenAPI enhancements do not need to handle a synthetic app.