Openapi custom context root 1.x #1524
Conversation
| * @return updated builder instance | ||
| */ | ||
| public Builder helidonConfig(Config config) { | ||
| config.get(CONFIG_PREFIX + ".web-context") |
There was a problem hiding this comment.
No prefix should be used, config should be on openapi node already.
Method should be called config
There was a problem hiding this comment.
This method, helidonConfig, has been present on SEOpenAPISupportBuilder in SE OpenAPI since we first created it, as has the expectation that the Config node passed in is the top-level one, within which openapi might exist.
Because we want to support Helidon config in MP also, this method is migrating to the superclass OpenAPISupport. So while it might appear that this is a new method, it is not a new part of the contract between SE OpenAPI and SE apps.
Changing either the method name or the expectation of which config node is passed - in 1.x anyway - would be a backward-incompatible change.
There was a problem hiding this comment.
We can make the incompatible change in the 2.x PR to align OpenAPI with the other components that have similar config support.
There was a problem hiding this comment.
For 1.x, we can add the config method as you suggest -- with a Config argument that should be the openapi node -- while keeping the existing helidonConfig method to preserve backward compatibility and mark helidonConfig as deprecated.
…precated; add parallel config method which accepts the openapi config node; related changes
Resolves #1350 for 1.x. Very similar to the 2.x changes for the same issue.