-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SE Reactive Messaging #1636
Merged
Merged
SE Reactive Messaging #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good/consistent. Let's work on some extended TestMessage types/use cases to prove it out. Will contact you... |
/trigger |
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Remove internal-test bundle Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Rebased and ready for review |
tomas-langer
requested changes
May 26, 2020
messaging/kafka/src/main/java/io/helidon/messaging/connectors/kafka/KafkaConfigBuilder.java
Outdated
Show resolved
Hide resolved
messaging/messaging/src/main/java/io/helidon/messaging/ConnectorConfigBuilder.java
Outdated
Show resolved
Hide resolved
messaging/messaging/src/main/java/io/helidon/messaging/ConnectorConfigBuilder.java
Outdated
Show resolved
Hide resolved
messaging/messaging/src/main/java/io/helidon/messaging/MessagingImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Merged
tomas-langer
approved these changes
May 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API
API is providing same functionality as MP Reactive Messaging does, number of method signatures is reduced to accommodate slightly different requirements of SE Helidon. For connectors is used same api as for MP connectors, which makes connectors reusable for both flawors.
Acknowledgement
Due to
no magic approach
implicit acknowledgement has been reduced only to methods providing unwrapped payload, as it wouldn't be possible to do manual ack withoutorg.eclipse.microprofile.reactive.messaging.Message
wrapper.Such messages are acked in preprocesses, right before unwrapping.
Kafka connector usage example:
Emitter usage example: