Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #1618 - Unable to initialize gRPC service when using helidon-… #1638

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Fix for #1618 - Unable to initialize gRPC service when using helidon-… #1638

merged 2 commits into from
Apr 16, 2020

Conversation

rlubke
Copy link
Contributor

@rlubke rlubke commented Apr 13, 2020

…microprofile-metrics2

  • Add methods grpc MetricsConfigurer relies on to resolve the IllegalAccesException
  • Ensure metric metadata is generated consistently; grpc code was generating metadata differently from the metric2 cdi bootstrap. This caused issues at runtime due to mismatched metadata.

@spericas spericas self-requested a review April 14, 2020 13:11
@spericas spericas added this to Normal priority in Backlog Apr 14, 2020
@rlubke
Copy link
Contributor Author

rlubke commented Apr 16, 2020

Thanks @spericas. Is there anything more needed from me?

@romain-grecourt romain-grecourt merged commit f67ffee into helidon-io:helidon-1.x Apr 16, 2020
Backlog automation moved this from Normal priority to Closed Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spericas spericas spericas approved these changes

Assignees

@rlubke rlubke

Labels
grpc metrics
Projects
Backlog
  
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rlubke @spericas @romain-grecourt