-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add custom runtime image guide, maven guide, gradle guide, refactored native image guide. #1639
Conversation
…d some typos in webserver javadocs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in the title of the PR: customer
-> custom
.
We've been using the term 'flavor' for a while now, I think it's better to rename the *-edition
attributes to *-flavor
.
docker run --rm -p 8080:8080 helidon-quickstart-{helidon-lc-edition}-jlink:latest | ||
---- | ||
|
||
You can exercise the application's endpoints as before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would also be worth showing passing script arguments, e.g. --test
or --help
just so it is clear how it is done, (and maybe that the port mappings isn't required).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an open issue (#1391) about the right way to add configuration to the pom for these plugins, say if you want to disable CDS or whatever. Yes, properties work, but they're a bit of a pain. And just pointing to the plugin docs is confusing, since they talk about adding the profile, which is already present now.
It would be best if we could resolve that issue and then show how to do it here.
I've add (an admittedly sparse) Maven Build Guide that shows examples of configuring the plugin and crossed referenced in the jlink guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
common
and using include and properties to generate edition specific document.